Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix： https://github.com/sofastack/sofa-registry/issues/121 #122

Merged
merged 1 commit into from
Aug 23, 2020
Merged

fix： https://github.com/sofastack/sofa-registry/issues/121 #122

merged 1 commit into from
Aug 23, 2020

Conversation

atellwu
Copy link
Contributor

@atellwu atellwu commented May 29, 2020

fix： #121

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes size/XS labels May 29, 2020
@atellwu atellwu added this to the 5.4.3 milestone May 29, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #122 into master will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #122      +/-   ##
============================================
- Coverage     62.63%   62.49%   -0.14%     
  Complexity       44       44              
============================================
  Files           429      429              
  Lines         15460    15465       +5     
  Branches       1489     1489              
============================================
- Hits           9683     9665      -18     
- Misses         4757     4782      +25     
+ Partials       1020     1018       -2
Impacted Files Coverage Δ Complexity Δ
...egistry/server/session/store/SessionInterests.java 79.61% <100.00%> (+0.09%) 0.00 <0.00> (ø)
.../bootstrap/MetaServerInitializerConfiguration.java 57.14% <0.00%> (-14.29%) 0.00% <0.00%> (ø%)
...sofa/registry/server/data/change/SnapshotData.java 90.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
...ting/sessionserver/disconnect/DisconnectEvent.java 66.66% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
...rver/session/node/service/DataNodeServiceImpl.java 60.55% <0.00%> (-6.67%) 0.00% <0.00%> (ø%)
...alipay/sofa/registry/remoting/bolt/BoltClient.java 58.00% <0.00%> (-2.00%) 0.00% <0.00%> (ø%)
...y/sofa/registry/task/batcher/AcceptorExecutor.java 71.90% <0.00%> (-1.66%) 0.00% <0.00%> (ø%)
...server/data/change/event/DataChangeEventQueue.java 89.15% <0.00%> (-1.59%) 0.00% <0.00%> (ø%)
...ver/session/bootstrap/SessionServerConfigBean.java 50.93% <0.00%> (-0.71%) 0.00% <0.00%> (ø%)
...a/registry/server/meta/store/DataStoreService.java 66.16% <0.00%> (-0.38%) 0.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b06d5c...126c0d5. Read the comment docs.

@dzdx dzdx merged commit a2a50d5 into sofastack:master Aug 23, 2020
nocvalight pushed a commit to nocvalight/sofa-registry that referenced this pull request Aug 23, 2020
@atellwu @nocvalight
fix： sofastack#121 (sofastack#122)
6def0d5 
Co-authored-by: kezhu.wukz <kezhu.wukz@alipay.com>
dzdx pushed a commit that referenced this pull request Dec 13, 2021
@atellwu
fix： #121 (#122)
a910454 
Co-authored-by: kezhu.wukz <kezhu.wukz@alipay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working cla:yes size/XS
Projects
None yet
Milestone
5.4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@atellwu @codecov-commenter @dzdx